VSB-TUO/Backport: align eager-themes with the other flicker backports#1320
Open
jr-rk wants to merge 1 commit into
Open
VSB-TUO/Backport: align eager-themes with the other flicker backports#1320jr-rk wants to merge 1 commit into
jr-rk wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rebuilds this follow-up on the current customer/vsb-tuo base (which now carries the final overlay mechanism #1318/#1321 and #1333). Drops the duplicate dspace eager-theme import (imported once as DSpaceEagerThemeModule and again, unaliased, as EagerThemeModule) so this file matches the canonical form on TUL/SAV/ZCU-DATA/ ZCU-PUB: dspace eager theme once + custom eager theme once. The earlier blank-page guard from this branch is intentionally dropped: #1321 removed the ds-app visibility:hidden rule (the overlay is now a purely visual mask), so the early-return can no longer hide the app, and the other customers took VSB-TUO's #1321 index.html verbatim. Keeping a guard only here would re-diverge index.html. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jr-rk
force-pushed
the
vsb-tuo/fe-fix-home-page-flicker-followup
branch
from
47d86ee to
8ba5816
Compare
jr-rk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Follow-up on
customer/vsb-tuo, kept in sync with the customer flicker-backport family (#1310 / #1311 / #1312 / #1314).All the SSR anti-flicker overlay work for VSB-TUO already landed on this base:
<ds-app>DOM settles; purely-visual mask so the live app stays interactive; closes dspace-customers#725), fix(ssr-overlay): render admin-sidebar gutter on the server so logged-in reload doesn't shift #1333 (admin-sidebar gutter).So the overlay fixes are already in the base. This PR carries the one remaining piece needed to match the other customers:
eager-themes.module.ts— drop the duplicate dspace eager-theme import (it was imported once asDSpaceEagerThemeModuleand again, unaliased, asEagerThemeModule, with both inimports[]). Result matches the canonical form now shared by TUL/SAV/ZCU-DATA/ZCU-PUB: dspace eager theme once + custom eager theme once.Dropped from this branch's earlier revision
The blank-page guard previously here is no longer needed: #1321 removed the
ds-app { visibility:hidden }rule (the overlay is now a purely visual mask), so the early-return can no longer leave the app hidden — and the other customers adopted #1321'sindex.htmlverbatim. Re-adding a guard only here would re-divergeindex.html.Related